[2.0.22] Online/Offline Status Images

[Rombo di Tuono]

Hi, and thank you for the mod.

I've a little problem, but unable to find the issue...

groupcp.php does not load the file groupcp_info_body.tpl

So that in groups page I see group list, but when I click view group (I'm admin) I see only header and footer, but not body (checking source of page confirms to me that the whole groupcp_info_body.tpl is missing)

I've checked the mod, and all seems ok...

Any idea on what should I check for?

Thank you.

[EXreaction]

Test the backup file of it you made before you installed the mod and see if it still does that.

Does it do that on any other pages?

[Rombo di Tuono]

No, only in groupcp. In the other pages it works fine.

I'm pretty sure, because i've tested previous version before your mod, I've not backup, but I can easily uninstall the mod.

Before doing that I wanna try to understand.

In another forum (identical) i got an error in the exact position:

Code: Select all

Parse error: syntax error, unexpected '}' in /membri/forumanicomio/includes/template.php(127) : eval()'d code on line 105



P.S. Yes, I've TWO identical forums, because, after your mod, I've copied files and DB for testing from one to other...

EDIT: I've removed the mod from one of two forums, and ALL works as before mod (works fine).

In the 2nd now I'm gonna trying ro remove mod ONLY from groupcp. then I'll post the result (I'm thinking issue is in the fact of I've increased ALL COLSPAN and -IMHO- SOME were not to increase )

BTW: is correct that:

if I have a table, with one <tr> section of 6 <td>, like this

Code: Select all

<tr>
   <td> some stuff </td>
   <td> some stuff </td>
   <td> some stuff </td>
   <td> some stuff </td>
   <td> some stuff </td>
   <td> some stuff </td>
<tr>

the next section MUST BE colspan="6", isn't it??

Code: Select all

<tr>
   <td colspan="6"> some other stuff </td>
<tr>

EDIT 2: OK: my fault is: I've not understood HOW TO modify groupcp_info_body.tpl !

In 2nd forum I've restored original, leaving all other files modded by your mod. AND NOW group panel works fine (without status, of course), and the rest of forum still indicate the online/offline status.

would you add some comments, or informations for me, please?

Thank you.

[EXreaction]

Don't edit extra things that are not asked to be changed by this mod. Your just going to break something.

Re-edit the groupcp_info_body.tpl, somewhere in there you have made a mistake in the editing.

[Rombo di Tuono]

Don't edit extra things that are not asked to be changed by this mod. Your just going to break something.

Re-edit the groupcp_info_body.tpl, somewhere in there you have made a mistake in the editing.

I'm sure of this. I haven't understood the sintax of:

Code: Select all

#
#-----[ FIND ]---------------------------------------------
# Note: This is not the full line
# Should be colspan="7"

colspan="{%:1}"

#
#-----[ INCREMENT ]-------------------------------------
# If you don't know how to use the increment, find colspan="7", replace it with colspan="8"

%:1 +1

#
#-----[ FIND ]---------------------------------------------
# Note: This is not the full line
# Should be colspan="7"

colspan="{%:1}"

#
#-----[ INCREMENT ]-------------------------------------
# If you don't know how to use the increment, find colspan="7", replace it with colspan="8"

%:1 +1



What does "colspan="{%:1}"" stand for?

The colspan="x" where x= 7 or 8 appears MANY TIMES in that file before the mod, so I don't understand WHAT increase and what NOT.

I've just tried to increase ONLY the "7" to "8", but doesn't work

EDIT: I DID IT !

Simply I do the mod to that file WITHOUT increasing ANY "colspan"

Don't know why... maybe later I'll check for that... Thank you...

[EXreaction]

You may break the layout of the page a bit if you skip the colspan edit, and you may break the page layout if you add it to the wrong places.

The increment action is exactly what it is named for, you increment the {%:#} sections with what it calls for with the relations it tells you, you would search for
colspan="

then add 1 to the number between the double quotes since it says +1 in the increment section.

You don't use ever place you find in a mod to change it, you find the first place with that code after the previous change you made.

[Rombo di Tuono]

You don't use ever place you find in a mod to change it, you find the first place with that code after the previous change you made.

Thank you, I thought this... for logic, not sure it was right... now I'm sure

That was 1st thing I made, but for some reason, my own tpl was increased yet... don't know why...

anyway, problem resolved and hints here for next guy banging head on this

Thank you very much.
Bye

[Philthy]

I found a conflict with the printer topics mod.
My users find the online/offline images very useful, especially when they want to PM someone quickly. I installed it a week or so ago, and haven't noticed the conflict with the printer topics mod until now. I get this error:
I tried to print a thread, and got this:
Fatal error: Call to undefined function: display_online_offline() in /var/www/html/forum/viewtopic.php on line 1380
line 1380 is part of the online/offline mod:

Code: Select all

// Start Online/Offline Status Images MOD
      'STATUS_IMG' => display_online_offline($poster_id, $online_array),
// End Online/Offline Status Images MOD

In order to print a thread a moment ago, I simply deleted these lines from viewtopic.php and clicked the link for the printer friendly topics....success!

Is there any way to get both working?
Here's a link to the printer friendly mod:
http://www.phpbb.com/community/viewtopic.php?t=141443

Thanks in advance
Phil

Edit to add:
It seems I'm not the only person with the same problem:
http://www.phpbb.com/community/viewtopi ... 8#p2952169

[EXreaction]

Could you send me your viewtopic.php file with the edits for each already in place?

[Philthy]

Could you send me your viewtopic.php file with the edits for each already in place?

Certainly can:

Code: Select all

Code removed to clean up the page

There are several mods that have affected this file as you can see.
Many thanks for your help.